Implement redirect-stdout-on-close on Winows, to the 'NUL' device.

Implement redirect-stdout-on-close on Winows, to the 'NUL' device.

BUG=https://code.google.com/p/dart/issues/detail?id=11593
R=kustermann@google.com, whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24578

[kustermann, 2013-06-28 10:10:14]

https://codereview.chromium.org/18194003/diff/1/runtime/bin/eventhandler_win.cc
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/18194003/diff/1/runtime/bin/eventhandler_win....
runtime/bin/eventhandler_win.cc:333: int fd = _open("NUL", _O_WRONLY);
Is this opening a file called "NUL" or an actual /dev/null-like device?

https://codereview.chromium.org/18194003/diff/1/runtime/bin/eventhandler_win....
runtime/bin/eventhandler_win.cc:336: USE(close(fd));
AFAIK USE() is not necessary here.
USE() is useful in cases where you store return values in a variable and don't
use the variable. Ignoring the return value of a function should be fine?!

[Anders Johnsen, 2013-06-28 10:19:11]

https://codereview.chromium.org/18194003/diff/1/runtime/bin/eventhandler_win.cc
File runtime/bin/eventhandler_win.cc (right):

https://codereview.chromium.org/18194003/diff/1/runtime/bin/eventhandler_win....
runtime/bin/eventhandler_win.cc:333: int fd = _open("NUL", _O_WRONLY);
On 2013/06/28 10:10:14, kustermann wrote:
> Is this opening a file called "NUL" or an actual /dev/null-like device?

Yep, check out http://en.wikipedia.org/wiki/%5CDevice%5CNull

https://codereview.chromium.org/18194003/diff/1/runtime/bin/eventhandler_win....
runtime/bin/eventhandler_win.cc:336: USE(close(fd));
On 2013/06/28 10:10:14, kustermann wrote:
> AFAIK USE() is not necessary here.
> USE() is useful in cases where you store return values in a variable and don't
> use the variable. Ignoring the return value of a function should be fine?!

I think you are right. Will try without.

[Bill Hesse, 2013-06-28 10:22:21]

lgtm

[kustermann, 2013-06-28 10:23:13]

lgtm

[Anders Johnsen, 2013-06-28 10:29:36]

Committed patchset #2 manually as r24578 (presubmit successful).