Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 18191019: Changed the code for running a test case to make beter use of dart:async. (Closed)

Created:
7 years, 5 months ago by gram
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changed the code for running a test case to make beter use of dart:async. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=24643

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -91 lines) Patch
M pkg/unittest/lib/src/test_case.dart View 1 3 chunks +43 lines, -83 lines 2 comments Download
M pkg/unittest/test/unittest_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 5 months ago (2013-06-29 06:09:58 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/18191019/diff/2001/pkg/unittest/lib/src/test_case.dart File pkg/unittest/lib/src/test_case.dart (right): https://codereview.chromium.org/18191019/diff/2001/pkg/unittest/lib/src/test_case.dart#newcode73 pkg/unittest/lib/src/test_case.dart:73: else stack = "$stack"; style: if-else need { ...
7 years, 5 months ago (2013-07-01 18:24:31 UTC) #2
gram
7 years, 5 months ago (2013-07-01 18:57:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r24643 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698