Issue 181843007: 1. Added new versions of Api::UnWrapStringHandle Api::UnWrapInstanceHandle to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181843007: 1. Added new versions of Api::UnWrapStringHandle Api::UnWrapInstanceHandle to (Closed)

Created:
6 years, 10 months ago by siva

Modified:
6 years, 9 months ago

Reviewers:
rmacnak, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

1. Added new versions of Api::UnWrapStringHandle Api::UnWrapInstanceHandle to use a reused handle instead of creating a new one 2. Use CHEK_ISOLATE instead of DARTSCOPE in some of the API functions where no handles are created R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=33142

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -45 lines)			Patch
M	runtime/vm/dart_api_impl.h	View	1	3 chunks	+10 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View		22 chunks	+71 lines, -38 lines	1 comment	Download
M	runtime/vm/reusable_handles.h	View	1 2	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

Committed patchset #4 manually as r33142 (presubmit successful).

6 years, 9 months ago (2014-02-27 23:38:42 UTC) #3

Ivan Posva

6 years, 9 months ago (2014-02-28 04:41:36 UTC) #4

Message was sent while issue was closed.

-Ivan

https://codereview.chromium.org/181843007/diff/60001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/181843007/diff/60001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:1370: Isolate* isolate = Isolate::Current();
Could we before doing any of the work below just do a quick class ID check?

Expand Messages | Collapse Messages