Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 18182010: Make html metadata follow the spec. (Closed)

Created:
7 years, 5 months ago by Andrei Mouravski
Modified:
7 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, blois
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed DocsEditable, Experimental, Unstable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12503 lines, -12497 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 533 chunks +3504 lines, -3504 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 528 chunks +3930 lines, -3930 lines 0 comments Download
M sdk/lib/html/html_common/metadata.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 30 chunks +130 lines, -130 lines 0 comments Download
M sdk/lib/indexed_db/dartium/indexed_db_dartium.dart View 1 25 chunks +113 lines, -113 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 163 chunks +1430 lines, -1430 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 160 chunks +1618 lines, -1618 lines 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 30 chunks +208 lines, -208 lines 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 36 chunks +238 lines, -238 lines 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 33 chunks +574 lines, -574 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 34 chunks +566 lines, -566 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 12 chunks +51 lines, -51 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 13 chunks +50 lines, -50 lines 0 comments Download
M tools/dom/docs/lib/docs.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 8 chunks +18 lines, -18 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/systemnative.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/dart2js_impl.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/dart_implementation.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/impl_MouseEvent.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_ClientRect.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 8 chunks +10 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Geolocation.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLCanvasElement.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate View 1 5 chunks +10 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLInputElement.darttemplate View 1 7 chunks +7 lines, -7 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTableElement.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTableRowElement.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTableSectionElement.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate View 1 5 chunks +6 lines, -6 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBDatabase.darttemplate View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_IDBFactory.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Location.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Navigator.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 1 chunk +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGColor.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Screen.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Touch.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_WebKitCSSKeyframesRule.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Andrei Mouravski
7 years, 5 months ago (2013-06-28 23:01:36 UTC) #1
scheglov
LGTM It can be used correctly with @Experimental().
7 years, 5 months ago (2013-06-28 23:06:48 UTC) #2
Andrei Mouravski
7 years, 5 months ago (2013-07-01 18:34:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r24638 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698