Issue 18175005: Updated tests for test.py after checked-in binary update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18175005: Updated tests for test.py after checked-in binary update (Closed)

Created:
7 years, 5 months ago by kustermann

Modified:
7 years, 5 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Updated tests for test.py after checked-in binary update R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=24574

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -11 lines)			Patch
M	tests/standalone/io/skipping_dart2js_compilations_helper.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/standalone/io/test_runner_exit_code_script.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	tests/standalone/io/test_runner_test.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	tests/standalone/standalone.status	View	3 chunks	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

https://codereview.chromium.org/18175005/diff/1/tests/standalone/io/test_runner_exit_code_script.dart File tests/standalone/io/test_runner_exit_code_script.dart (right): https://codereview.chromium.org/18175005/diff/1/tests/standalone/io/test_runner_exit_code_script.dart#newcode13 tests/standalone/io/test_runner_exit_code_script.dart:13: var progressType = new Options().arguments[0]; this is actually "wrong" ...

7 years, 5 months ago (2013-06-28 08:28:33 UTC) #2

kustermann

7 years, 5 months ago (2013-06-28 08:35:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r24574 (presubmit successful).

Expand Messages | Collapse Messages