Issue 18170003: Fix bug in the inliner when dealing with named optional parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18170003: Fix bug in the inliner when dealing with named optional parameters. (Closed)

Created:
7 years, 5 months ago by Florian Schneider

Modified:
7 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug in the inliner when dealing with named optional parameters. In case of a name mismatch the inliner would still inline the target method as if nothing was wrong. Added a check that all actual named arguments are matched against a formal parameter. TEST=tests/language/named_parameters_with_conversions_test.dart R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=24954

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -11 lines)			Patch
	M	runtime/vm/flow_graph_inliner.cc	View		7 chunks	+15 lines, -8 lines	0 comments	Download
	M	tests/language/named_parameters_with_conversions_test.dart	View		4 chunks	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

This bug existed in a long time (probably since inlining with named parameters was enabled), ...

7 years, 5 months ago (2013-07-12 12:26:11 UTC) #1

Florian Schneider

7 years, 5 months ago (2013-07-12 16:02:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r24954 (presubmit successful).

Expand Messages | Collapse Messages