Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 18170002: Properly handle empty stack traces in package:stack_trace. (Closed)

Created:
7 years, 5 months ago by nweiz
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Properly handle empty stack traces in package:stack_trace. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=24571

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pkg/stack_trace/lib/src/trace.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/stack_trace/test/trace_test.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 5 months ago (2013-06-28 01:41:06 UTC) #1
Siggi Cherem (dart-lang)
lgtm!
7 years, 5 months ago (2013-06-28 01:43:02 UTC) #2
nweiz
7 years, 5 months ago (2013-06-28 01:50:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24571 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698