Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 18167002: Add support for V8 and Firefox stack traces in pkg/stack_trace. (Closed)

Created:
7 years, 5 months ago by nweiz
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for V8 and Firefox stack traces in pkg/stack_trace. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=24569

Patch Set 1 #

Patch Set 2 : Make the browser tests work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+450 lines, -147 lines) Patch
M pkg/pkg.status View 1 4 chunks +3 lines, -3 lines 0 comments Download
pkg/stack_trace/lib/src/frame.dart View 1 3 chunks +61 lines, -7 lines 0 comments Download
M pkg/stack_trace/lib/src/trace.dart View 1 2 chunks +31 lines, -3 lines 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 1 4 chunks +178 lines, -83 lines 0 comments Download
M pkg/stack_trace/test/trace_test.dart View 1 2 chunks +68 lines, -51 lines 0 comments Download
A pkg/stack_trace/test/vm_test.dart View 1 chunk +109 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
7 years, 5 months ago (2013-06-28 00:17:28 UTC) #1
nweiz
7 years, 5 months ago (2013-06-28 01:09:19 UTC) #2
Jennifer Messerly
lgtm
7 years, 5 months ago (2013-06-28 01:16:38 UTC) #3
nweiz
7 years, 5 months ago (2013-06-28 01:22:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24569 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698