Issue 18156006: Fix minified signature generation.

Issue 18156006: Fix minified signature generation. (Closed)

Created:
7 years, 5 months ago by Johnni Winther

Modified:
7 years, 5 months ago

Reviewers:
erikcorry, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix minified signature generation. BUG=dartbug.com/11469 R=erikcorry@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=24715 Committed: https://code.google.com/p/dart/source/detail?r=24773

Patch Set 2 : Restrict use of fixed names to this-elements. #

Total comments: 2

Patch Set 4 : Updated cf. comment. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
	M	tests/language/language_dart2js.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

Committed patchset #1 manually as r24715 (presubmit successful).

7 years, 5 months ago (2013-07-03 05:45:43 UTC) #3

karlklose

LGTM. https://codereview.chromium.org/18156006/diff/5001/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right): https://codereview.chromium.org/18156006/diff/5001/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart#newcode1370 sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1370: String thisName = thisElement.hasFixedBackendName() Is that always the ...

7 years, 5 months ago (2013-07-04 09:54:09 UTC) #5

Johnni Winther

Committed patchset #4 manually as r24773 (presubmit successful).

7 years, 5 months ago (2013-07-04 12:08:12 UTC) #6

Johnni Winther

7 years, 5 months ago (2013-07-04 12:10:38 UTC) #7

Message was sent while issue was closed.

https://codereview.chromium.org/18156006/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/18156006/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:1370: String
thisName = thisElement.hasFixedBackendName()
On 2013/07/04 09:54:09, karlklose wrote:
> Is that always the case? Add an assert then?

It seems so.

Expand Messages | Collapse Messages