Add 'address' and 'port' to SocketException, and include them in toString().

Add 'address' and 'port' to SocketException, and include them in toString().

BUG=
R=whesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24784

[Bill Hesse, 2013-07-05 12:26:35]

LGTM.

https://codereview.chromium.org/18154005/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/18154005/diff/1/runtime/bin/socket_patch.dart...
runtime/bin/socket_patch.dart:290: throw createError(response, "Failed host name
lookup");
Address is not set at this point, and host is a String.  Could you add it to the
response string?

https://codereview.chromium.org/18154005/diff/1/runtime/bin/socket_patch.dart...
runtime/bin/socket_patch.dart:302: throw createError(result, "Connection
failed", address, post);
port

https://codereview.chromium.org/18154005/diff/1/runtime/bin/socket_patch.dart...
runtime/bin/socket_patch.dart:631: var e = createError(error, message, address,
port);
We don't have a .port on _NativeSocket.  There is localPort.  Do you want to get
these from "this", or pass them in?

https://codereview.chromium.org/18154005/diff/1/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/18154005/diff/1/sdk/lib/io/socket.dart#newcod...
sdk/lib/io/socket.dart:490: }
Of course, we are now missing ": " if both message and osError are null.  But
that shouldn't happen.

[Anders Johnsen, 2013-07-05 12:36:01]

https://codereview.chromium.org/18154005/diff/1/runtime/bin/socket_patch.dart
File runtime/bin/socket_patch.dart (right):

https://codereview.chromium.org/18154005/diff/1/runtime/bin/socket_patch.dart...
runtime/bin/socket_patch.dart:290: throw createError(response, "Failed host name
lookup");
On 2013/07/05 12:26:35, Bill Hesse wrote:
> Address is not set at this point, and host is a String.  Could you add it to
the
> response string?

Done.

https://codereview.chromium.org/18154005/diff/1/runtime/bin/socket_patch.dart...
runtime/bin/socket_patch.dart:302: throw createError(result, "Connection
failed", address, post);
On 2013/07/05 12:26:35, Bill Hesse wrote:
> port

Done.

https://codereview.chromium.org/18154005/diff/1/runtime/bin/socket_patch.dart...
runtime/bin/socket_patch.dart:631: var e = createError(error, message, address,
port);
On 2013/07/05 12:26:35, Bill Hesse wrote:
> We don't have a .port on _NativeSocket.  There is localPort.  Do you want to
get
> these from "this", or pass them in?

Done.

https://codereview.chromium.org/18154005/diff/1/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/18154005/diff/1/sdk/lib/io/socket.dart#newcod...
sdk/lib/io/socket.dart:490: }
On 2013/07/05 12:26:35, Bill Hesse wrote:
> Of course, we are now missing ": " if both message and osError are null.  But
> that shouldn't happen.

Nope.

[Anders Johnsen, 2013-07-05 12:36:17]

Committed patchset #2 manually as r24784 (presubmit successful).