Add flag to pin and service command to release isolates

Add flag to pin and service command to release isolates

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=33125

[Ivan Posva, 2014-02-27 18:07:15]

-Ivan

https://codereview.chromium.org/181503006/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/181503006/diff/1/runtime/vm/isolate.cc#newcod...
runtime/vm/isolate.cc:427: result->CreatePinPort();
How about:
if (FLAG_pin_isolates) {
  result->CreatePinPort();
}

CreatePinPort reads not like a conditional so to the casual reader it means.
Create the pin port no matter what.

https://codereview.chromium.org/181503006/diff/1/runtime/vm/isolate.cc#newcod...
runtime/vm/isolate.cc:444: if (!FLAG_pin_isolates) {
See above.

https://codereview.chromium.org/181503006/diff/1/runtime/vm/isolate.cc#newcod...
runtime/vm/isolate.cc:455: if (!FLAG_pin_isolates) {
This is equivalent to the pin_port_ == 0 condition below. Just remove it as we
unconditionally want to close the pin port here.

https://codereview.chromium.org/181503006/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/181503006/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:1095: // TODO(johnmccutchan): What do I respond with??
How about responding with something that brings up the main observatory page?

https://codereview.chromium.org/181503006/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:1114: { "release", HandleRelease },
release sounds too generic. How about releaseIsolate or release_isolate?

[Cutch, 2014-02-27 18:13:47]

https://codereview.chromium.org/181503006/diff/1/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/181503006/diff/1/runtime/vm/isolate.cc#newcod...
runtime/vm/isolate.cc:427: result->CreatePinPort();
On 2014/02/27 18:07:16, Ivan Posva wrote:
> How about:
> if (FLAG_pin_isolates) {
>   result->CreatePinPort();
> }
> 
> CreatePinPort reads not like a conditional so to the casual reader it means.
> Create the pin port no matter what.

Done.

https://codereview.chromium.org/181503006/diff/1/runtime/vm/isolate.cc#newcod...
runtime/vm/isolate.cc:444: if (!FLAG_pin_isolates) {
On 2014/02/27 18:07:16, Ivan Posva wrote:
> See above.

Done.

https://codereview.chromium.org/181503006/diff/1/runtime/vm/isolate.cc#newcod...
runtime/vm/isolate.cc:455: if (!FLAG_pin_isolates) {
On 2014/02/27 18:07:16, Ivan Posva wrote:
> This is equivalent to the pin_port_ == 0 condition below. Just remove it as we
> unconditionally want to close the pin port here.

Done.

https://codereview.chromium.org/181503006/diff/1/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/181503006/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:1095: // TODO(johnmccutchan): What do I respond with??
On 2014/02/27 18:07:16, Ivan Posva wrote:
> How about responding with something that brings up the main observatory page?

Punting on this for now.

https://codereview.chromium.org/181503006/diff/1/runtime/vm/service.cc#newcod...
runtime/vm/service.cc:1114: { "release", HandleRelease },
On 2014/02/27 18:07:16, Ivan Posva wrote:
> release sounds too generic. How about releaseIsolate or release_isolate?

"unpin".

[Cutch, 2014-02-27 18:14:57]

Committed patchset #2 manually as r33125 (presubmit successful).