Chromium Code Reviews

Issue 18143002: Reorganize some pub libraries. (Closed)

Created:
7 years, 5 months ago by Bob Nystrom
Modified:
7 years, 5 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove some newlines. #

Unified diffs Side-by-side diffs Stats (+127 lines, -1291 lines)
M sdk/lib/_internal/pub/lib/src/command.dart View 1 chunk +10 lines, -8 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/command/cache.dart View 1 chunk +4 lines, -4 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/command/deploy.dart View 2 chunks +6 lines, -6 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/command/help.dart View 1 chunk +6 lines, -6 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/command/install.dart View 1 chunk +4 lines, -4 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/command/lish.dart View 2 chunks +12 lines, -12 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/command/update.dart View 1 chunk +4 lines, -4 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/command/uploader.dart View 2 chunks +10 lines, -10 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/command/version.dart View 1 chunk +5 lines, -5 lines 0 comments
D sdk/lib/_internal/pub/lib/src/command_cache.dart View 1 chunk +0 lines, -48 lines 0 comments
D sdk/lib/_internal/pub/lib/src/command_deploy.dart View 1 chunk +0 lines, -141 lines 0 comments
D sdk/lib/_internal/pub/lib/src/command_help.dart View 1 chunk +0 lines, -36 lines 0 comments
D sdk/lib/_internal/pub/lib/src/command_install.dart View 1 chunk +0 lines, -31 lines 0 comments
D sdk/lib/_internal/pub/lib/src/command_lish.dart View 1 chunk +0 lines, -172 lines 0 comments
D sdk/lib/_internal/pub/lib/src/command_update.dart View 1 chunk +0 lines, -45 lines 0 comments
D sdk/lib/_internal/pub/lib/src/command_uploader.dart View 1 chunk +0 lines, -82 lines 0 comments
D sdk/lib/_internal/pub/lib/src/command_version.dart View 1 chunk +0 lines, -22 lines 0 comments
M sdk/lib/_internal/pub/lib/src/dart.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/directory_tree.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/entrypoint.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/error_group.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/exit_codes.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/git.dart View 1 chunk +1 line, -1 line 0 comments
D sdk/lib/_internal/pub/lib/src/git_source.dart View 1 chunk +0 lines, -211 lines 0 comments
D sdk/lib/_internal/pub/lib/src/hosted_source.dart View 1 chunk +0 lines, -262 lines 0 comments
M sdk/lib/_internal/pub/lib/src/lock_file.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/log.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/oauth2.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/package.dart View 1 chunk +1 line, -1 line 0 comments
D sdk/lib/_internal/pub/lib/src/path_source.dart View 1 chunk +0 lines, -118 lines 0 comments
M sdk/lib/_internal/pub/lib/src/pubspec.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/safe_http_server.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/sdk.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/solver/version_solver.dart View 2 chunks +3 lines, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/source.dart View 1 chunk +1 line, -1 line 0 comments
A + sdk/lib/_internal/pub/lib/src/source/git.dart View 1 chunk +8 lines, -8 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/source/hosted.dart View 2 chunks +10 lines, -10 lines 0 comments
A + sdk/lib/_internal/pub/lib/src/source/path.dart View 1 chunk +8 lines, -8 lines 0 comments
M sdk/lib/_internal/pub/lib/src/source_registry.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/system_cache.dart View 1 chunk +4 lines, -4 lines 0 comments
M sdk/lib/_internal/pub/lib/src/utils.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/validator.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/validator/compiled_dartdoc.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/validator/dependency.dart View 1 chunk +3 lines, -3 lines 0 comments
M sdk/lib/_internal/pub/lib/src/validator/directory.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/validator/lib.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/validator/license.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/validator/name.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/validator/pubspec_field.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/validator/size.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/lib/src/version.dart View 1 chunk +1 line, -1 line 0 comments
M sdk/lib/_internal/pub/test/test_pub.dart View 1 chunk +3 lines, -3 lines 0 comments

Messages

Total messages: 5 (0 generated)
Bob Nystrom
7 years, 5 months ago (2013-06-27 21:02:32 UTC) #1
nweiz
One comment, otherwise lgtm https://codereview.chromium.org/18143002/diff/1/sdk/lib/_internal/pub/lib/src/exit_codes.dart File sdk/lib/_internal/pub/lib/src/exit_codes.dart (right): https://codereview.chromium.org/18143002/diff/1/sdk/lib/_internal/pub/lib/src/exit_codes.dart#newcode10 sdk/lib/_internal/pub/lib/src/exit_codes.dart:10: I like not having a ...
7 years, 5 months ago (2013-06-27 21:34:03 UTC) #2
Bob Nystrom
Thanks! https://codereview.chromium.org/18143002/diff/1/sdk/lib/_internal/pub/lib/src/exit_codes.dart File sdk/lib/_internal/pub/lib/src/exit_codes.dart (right): https://codereview.chromium.org/18143002/diff/1/sdk/lib/_internal/pub/lib/src/exit_codes.dart#newcode10 sdk/lib/_internal/pub/lib/src/exit_codes.dart:10: On 2013/06/27 21:34:03, nweiz wrote: > I like ...
7 years, 5 months ago (2013-06-27 21:46:50 UTC) #3
Bob Nystrom
Committed patchset #2 manually as r24555 (presubmit successful).
7 years, 5 months ago (2013-06-27 21:47:19 UTC) #4
nweiz
7 years, 5 months ago (2013-06-27 22:43:31 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/18143002/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/exit_codes.dart (right):

https://codereview.chromium.org/18143002/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/exit_codes.dart:10: 
On 2013/06/27 21:46:51, Bob Nystrom wrote:
> On 2013/06/27 21:34:03, nweiz wrote:
> > I like not having a newline here. It makes the doc comment look like it's
> > attached to the library name.
> 
> Done.
> 
> So the rule is a blank line after the copyright header, but not between the
> library tag and doc comment if there is one?

Yep.

Powered by Google App Engine