Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18140005: Report TYPE_ALIAS_CANNOT_REFERENCE_ITSELF (Closed)

Created:
7 years, 5 months ago by scheglov
Modified:
7 years, 5 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report TYPE_ALIAS_CANNOT_REFERENCE_ITSELF R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24568

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweak #

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 5 months ago (2013-06-27 22:27:41 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/18140005/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/18140005/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode4001 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:4001: private boolean checkForTypeAliastCannotReferenceItself(FunctionTypeAlias node) { "Aliast" --> "Alias"
7 years, 5 months ago (2013-06-28 00:36:34 UTC) #2
scheglov
7 years, 5 months ago (2013-06-28 01:12:37 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r24568 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698