Issue 18140004: Report EQUALITY_CANNOT_BE_EQUALITY_OPERAND

Issue 18140004: Report EQUALITY_CANNOT_BE_EQUALITY_OPERAND (Closed)

Created:
7 years, 5 months ago by scheglov

Modified:
7 years, 5 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report EQUALITY_CANNOT_BE_EQUALITY_OPERAND R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24560

Patch Set 2 : Additional test #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -8 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/ParserErrorCode.java	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ComplexParserTest.java	View		2 chunks	+6 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/RecoveryParserTest.java	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/co19/co19-analyzer.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/18140004/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java (right): https://codereview.chromium.org/18140004/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java#newcode386 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:386: public void test_equalityCannotBeEqualityOperand_eq_neq() throws Exception { It might ...

7 years, 5 months ago (2013-06-27 22:12:17 UTC) #2

scheglov

https://codereview.chromium.org/18140004/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java (right): https://codereview.chromium.org/18140004/diff/1/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java#newcode386 editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java:386: public void test_equalityCannotBeEqualityOperand_eq_neq() throws Exception { On 2013/06/27 22:12:17, ...

7 years, 5 months ago (2013-06-27 22:31:36 UTC) #4

scheglov

7 years, 5 months ago (2013-06-27 22:31:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r24560 (presubmit successful).

Expand Messages | Collapse Messages