Refactoring resolvers to make them able to be run in parallel.

Refactoring resolvers to make them able to be run in parallel.

With pub build and pub serve the same transformer can be run on the same asset in parallel. We want to maintain the cache between the runs, so making the resolver pipeline these requests.

In addition, refactoring to dramatically change the role of ResolverTransformer- previously it was a transformer that automatically kept the AST up to date, but this does not work well when in a pipeline of transformers that are generating or modifying code. What was ResolverTransformer is Resolvers- a cache of resolvers for which individual transformers now need to request the resolver from.

ResolverTransformer is now a mixin which can be used to automatically release a Resolver when it's done being used.

BUG=
R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33163

[Siggi Cherem (dart-lang), 2014-02-27 18:20:35]

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolver_impl.dart (right):

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:92: });
style nit: use (_) => this, maybe fold into the previous then block?

For example:

var future = _lastPhaseComplete.then((_) {
   _currentPhaseComplete = phaseComplete;
   return _performResolve(transform).then((_) => this);
}


Alternatively, you could do:

var future = _lastPhaseComplete
   .then((_) { _currentPhaseComplete = phaseComplete; })
   .then((_) => _performResolve(transform))
   .then((_) => this);

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolvers.dart (right):

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolvers.dart:13: /// Barback-based code resolver
which maintains up-to-date resolved ASTs for the
update comment?

In particular, I was a bit confused because it doesn't seems to apply to the
class below, but more as a comment for [Resolver].

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/te...
File pkg/code_transformers/test/resolver_test.dart (right):

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/te...
pkg/code_transformers/test/resolver_test.dart:347: class TestTransformer extends
Transformer with ResolverTransformer{
nit: add space before '{'

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/te...
pkg/code_transformers/test/resolver_test.dart:349: final Function test;
nit: consider renaming this to avoid shadowing unittest#test?

[blois, 2014-02-27 23:47:16]

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolver_impl.dart (right):

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolver_impl.dart:92: });
On 2014/02/27 18:20:41, Siggi Cherem (dart-lang) wrote:
> style nit: use (_) => this, maybe fold into the previous then block?
> 
> For example:
> 
> var future = _lastPhaseComplete.then((_) {
>    _currentPhaseComplete = phaseComplete;
>    return _performResolve(transform).then((_) => this);
> }
> 
> 
> Alternatively, you could do:
> 
> var future = _lastPhaseComplete
>    .then((_) { _currentPhaseComplete = phaseComplete; })
>    .then((_) => _performResolve(transform))
>    .then((_) => this);

Done.

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolvers.dart (right):

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolvers.dart:13: /// Barback-based code resolver
which maintains up-to-date resolved ASTs for the
On 2014/02/27 18:20:41, Siggi Cherem (dart-lang) wrote:
> update comment?
> 
> In particular, I was a bit confused because it doesn't seems to apply to the
> class below, but more as a comment for [Resolver].

Done.

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/te...
File pkg/code_transformers/test/resolver_test.dart (right):

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/te...
pkg/code_transformers/test/resolver_test.dart:347: class TestTransformer extends
Transformer with ResolverTransformer{
On 2014/02/27 18:20:41, Siggi Cherem (dart-lang) wrote:
> nit: add space before '{'

Done.

https://codereview.chromium.org/181383015/diff/20001/pkg/code_transformers/te...
pkg/code_transformers/test/resolver_test.dart:349: final Function test;
On 2014/02/27 18:20:41, Siggi Cherem (dart-lang) wrote:
> nit: consider renaming this to avoid shadowing unittest#test?

Done.

[Siggi Cherem (dart-lang), 2014-02-28 01:45:12]

lgtm, thanks!

https://codereview.chromium.org/181383015/diff/40001/pkg/code_transformers/li...
File pkg/code_transformers/lib/src/resolvers.dart (right):

https://codereview.chromium.org/181383015/diff/40001/pkg/code_transformers/li...
pkg/code_transformers/lib/src/resolvers.dart:13: /// Barback-based code resolver
which maintains up-to-date resolved ASTs for the
resolver => resolvers?

[blois, 2014-02-28 16:58:23]

Committed patchset #2 manually as r33163 (presubmit successful).