Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 181383009: Relax string literal requirements on arguments (Closed)

Created:
6 years, 10 months ago by Alan Knight
Modified:
6 years, 10 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Relax string literal requirements on arguments BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=33103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M pkg/intl/lib/src/intl_message.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/intl/test/message_extraction/part_of_sample_with_messages.dart View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
We were rejecting messages with multi-line string descriptions
6 years, 10 months ago (2014-02-26 23:20:01 UTC) #1
Emily Fortuna
lgtm
6 years, 10 months ago (2014-02-27 00:22:34 UTC) #2
Alan Knight
6 years, 10 months ago (2014-02-27 00:25:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698