Issue 18131005: standalone/typed_array_test mostly passes on dart2js + d8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18131005: standalone/typed_array_test mostly passes on dart2js + d8 (Closed)

Created:
7 years, 5 months ago by sra1

Modified:
7 years, 5 months ago

Reviewers:
srdjan, siva

CC:
reviews_dartlang.org, vsm

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

standalone/typed_array_test mostly passes on dart2js + d8 Split int64+uint64 into separate test to that the test can pass on dart2js. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=24702

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -69 lines)			Patch
M	tests/standalone/standalone.status	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
A	tests/standalone/typed_array_int64_uint64_test.dart	View		1 chunk	+79 lines, -0 lines	0 comments	Download
M	tests/standalone/typed_array_test.dart	View		3 chunks	+3 lines, -67 lines	0 comments	Download

Total messages: 3 (0 generated)

sra1

byte_array_view_optimized_test also passes on dart2js. I have a concern about byte_array_view_optimized_test. Does the change in ...

7 years, 5 months ago (2013-07-02 01:44:33 UTC) #1

siva

LGTM. Can you file a bug with regards to byte_array_view_optimized_test.dart (I thought the consensus was ...

7 years, 5 months ago (2013-07-02 15:42:56 UTC) #2

sra1

7 years, 5 months ago (2013-07-02 18:15:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r24702 (presubmit successful).