Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 18129004: Simplify constructors translation, improve code style. (Closed)

Created:
7 years, 5 months ago by scheglov
Modified:
7 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Simplify constructors translation, improve code style. This CL stops generating and using "_impl" methods with constructor implementation. This is actually required only locally, when there are other statements aside of redirecting constructor invocation. So, this may be done later, during constructors optimizing in ConstructorSemanticProcessor. For now we just transform placeholder of redirecting constructor invocation into the actual initializer. Also, this CL adds more optimizations into ConstructorSemanticProcessor, such as: 1. removing empty constructor body; 2. enum constructor tweaks. Plus new snapshot of analyzer_experimental with these changes in translation applied. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24701

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1116 lines, -1228 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart View 1 chunk +5 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/Context.java View 9 chunks +35 lines, -44 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 15 chunks +75 lines, -151 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/engine/MainEngine.java View 2 chunks +0 lines, -2 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ConstructorSemanticProcessor.java View 2 chunks +150 lines, -33 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java View 18 chunks +22 lines, -97 lines 1 comment Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SyntaxTranslatorTest.java View 3 chunks +4 lines, -14 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ConstructorSemanticProcessorTest.java View 2 chunks +39 lines, -16 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java View 1 chunk +4 lines, -20 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/ast.dart View 13 chunks +20 lines, -41 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/constant.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/element.dart View 54 chunks +55 lines, -187 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/engine.dart View 56 chunks +238 lines, -208 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/error.dart View 8 chunks +70 lines, -70 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/html.dart View 3 chunks +6 lines, -15 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/instrumentation.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/java_io.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/parser.dart View 3 chunks +15 lines, -13 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/resolver.dart View 21 chunks +123 lines, -81 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/scanner.dart View 4 chunks +10 lines, -34 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source.dart View 3 chunks +5 lines, -14 lines 0 comments Download
M pkg/analyzer_experimental/lib/src/generated/source_io.dart View 4 chunks +9 lines, -25 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/ast_test.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/parser_test.dart View 5 chunks +23 lines, -1 line 0 comments Download
M pkg/analyzer_experimental/test/generated/resolver_test.dart View 8 chunks +179 lines, -130 lines 0 comments Download
M pkg/analyzer_experimental/test/generated/test_support.dart View 1 chunk +4 lines, -11 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +17 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 5 months ago (2013-07-01 22:09:45 UTC) #1
Brian Wilkerson
LGTM. The resulting code is *much* cleaner! https://codereview.chromium.org/18129004/diff/1/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java File editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java (right): https://codereview.chromium.org/18129004/diff/1/editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java#newcode790 editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/SemanticTest.java:790: // TODO(scheglov) ...
7 years, 5 months ago (2013-07-02 14:21:45 UTC) #2
scheglov
7 years, 5 months ago (2013-07-02 17:45:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24701 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698