Utility methods used for dartium debugger integration.

Utility methods used for dartium debugger integration.
In addition, added back two DOM methods required by the chrome dev tools that had been removed from dart:html
I'm not thrilled about adding back className but the devtools use className in 495 places so figuring out which places are actually talking about classNames of inspected objects and which ones are just internal uses of className inside the devtools would be a pain.
As the browser has a String "class" attribute I do think it is natural to provide at least a read only className in addition to classes.

This changes goes along with the larger CL
https://codereview.chromium.org/18169002/
which I will be sending out for general review in a little bit.


BUG=
R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25032

Committed: https://code.google.com/p/dart/source/detail?r=28904

[Jacob, 2013-07-12 21:19:46]

ready for review

[blois, 2013-07-12 21:30:38]

https://codereview.chromium.org/18125007/diff/5001/tools/dom/scripts/htmlrena...
File tools/dom/scripts/htmlrenamer.py (left):

https://codereview.chromium.org/18125007/diff/5001/tools/dom/scripts/htmlrena...
tools/dom/scripts/htmlrenamer.py:676: 'Node.get:nodeName',
Should re-gen w/ go.sh to update dart2js as well.

https://codereview.chromium.org/18125007/diff/5001/tools/dom/src/native_DOMIm...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/18125007/diff/5001/tools/dom/src/native_DOMIm...
tools/dom/src/native_DOMImplementation.dart:76: // with the Dart C mirrors API
simpler.
Does seem like an internal library would be a better fit.

https://codereview.chromium.org/18125007/diff/5001/tools/dom/src/native_DOMIm...
tools/dom/src/native_DOMImplementation.dart:86: int endIndex =
name.indexOf('@');
lastIndexOf?

[Jacob, 2013-07-12 22:01:54]

https://codereview.chromium.org/18125007/diff/5001/tools/dom/src/native_DOMIm...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/18125007/diff/5001/tools/dom/src/native_DOMIm...
tools/dom/src/native_DOMImplementation.dart:76: // with the Dart C mirrors API
simpler.
On 2013/07/12 21:30:38, blois wrote:
> Does seem like an internal library would be a better fit.
do you care if I move it to an internal library now or later? Placing it in the
_Utils private class is convenient as there is already a helper method in
DartUtilities.cpp to invoke static methods on that class.

https://codereview.chromium.org/18125007/diff/5001/tools/dom/src/native_DOMIm...
tools/dom/src/native_DOMImplementation.dart:86: int endIndex =
name.indexOf('@');
On 2013/07/12 21:30:38, blois wrote:
> lastIndexOf?

valid dart member names cannot contain @ so I think indexOf is correct
You'd want
"foo@bar@baz" to strip down to just "foo"

[Jacob, 2013-07-12 22:24:53]

ran go.sh and fixed cases were $dom_className was used.

[blois, 2013-07-12 23:50:18]

lgtm

[Jacob, 2013-07-15 22:57:12]

Committed patchset #2 manually as r25032 (presubmit successful).

[Jacob, 2013-10-19 04:58:49]

Committed patchset #3 manually as r28904 (presubmit successful).