Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 18121013: Allow selectors for test.py to match against a subtest of a multitest (Closed)

Created:
7 years, 5 months ago by kustermann
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org, ricow1, ahe
Visibility:
Public.

Description

Allow selectors for test.py to match against a subtest of a multitest Previously we were not able to select a subtest of a multitest (i.e. "tools/test.py suite/path-to-test/01"). R=johnniwinther@google.com, karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=24782

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M tools/testing/dart/test_suite.dart View 1 2 chunks +14 lines, -13 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
kustermann
https://codereview.chromium.org/18121013/diff/1002/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/18121013/diff/1002/tools/testing/dart/test_suite.dart#newcode624 tools/testing/dart/test_suite.dart:624: group.add(doMultitest(filePath, buildDir, suiteDir, createTestCase)); doMultitest() will basically call [createTestCase] ...
7 years, 5 months ago (2013-07-05 08:41:37 UTC) #1
Johnni Winther
lgtm
7 years, 5 months ago (2013-07-05 08:48:27 UTC) #2
kustermann
Thank you.
7 years, 5 months ago (2013-07-05 08:50:07 UTC) #3
karlklose
LGTM.
7 years, 5 months ago (2013-07-05 08:50:20 UTC) #4
kustermann
7 years, 5 months ago (2013-07-05 08:50:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r24782 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698