Issue 18097007: Add SecureSocket.addCertificate.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+224 lines, -40 lines)			Patch
M	runtime/bin/io_natives.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/bin/secure_socket.cc	View	1 2 3	2 chunks	+86 lines, -38 lines	0 comments	Download
M	runtime/bin/secure_socket_patch.dart	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	1 2 3 4	3 chunks	+37 lines, -1 line	0 comments	Download
A	tests/standalone/io/certificate_test.dart	View	1 2	1 chunk	+38 lines, -0 lines	0 comments	Download
A	tests/standalone/io/certificate_test_client.dart	View	1 2 3 4	1 chunk	+41 lines, -0 lines	0 comments	Download
A	tests/standalone/io/pkcert/myauthority.pem	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

https://codereview.chromium.org/18097007/diff/5001/runtime/bin/secure_socket.cc File runtime/bin/secure_socket.cc (right): https://codereview.chromium.org/18097007/diff/5001/runtime/bin/secure_socket.cc#newcode281 runtime/bin/secure_socket.cc:281: static Dart_Handle X509FromCertificate(CERTCertificate* certificate) { This function is just ...

7 years, 4 months ago (2013-07-29 11:22:13 UTC) #1

Søren Gjesse

LGTM! https://codereview.chromium.org/18097007/diff/8001/sdk/lib/io/secure_socket.dart File sdk/lib/io/secure_socket.dart (right): https://codereview.chromium.org/18097007/diff/8001/sdk/lib/io/secure_socket.dart#newcode220 sdk/lib/io/secure_socket.dart:220: * For example, 'TC,,' specifies that the certificate ...

7 years, 4 months ago (2013-07-29 14:12:19 UTC) #2

Bill Hesse

https://codereview.chromium.org/18097007/diff/8001/sdk/lib/io/secure_socket.dart File sdk/lib/io/secure_socket.dart (right): https://codereview.chromium.org/18097007/diff/8001/sdk/lib/io/secure_socket.dart#newcode220 sdk/lib/io/secure_socket.dart:220: * For example, 'TC,,' specifies that the certificate is ...

7 years, 4 months ago (2013-07-30 10:00:10 UTC) #3

Bill Hesse

7 years, 4 months ago (2013-07-30 10:01:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #5 manually as r25610 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18097007: Add SecureSocket.addCertificate. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add test. #

Patch Set 3 : Remove nickname argument. #

Patch Set 4 : Improve formatting #

Patch Set 5 : Add documentation link, and some constant trust strings. #

Messages