Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 18089016: Fixing type error for WebGL's getShaderParameter. (Closed)

Created:
7 years, 5 months ago by blois
Modified:
7 years, 5 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, kasperl
Visibility:
Public.

Description

Fixing type error for WebGL's getShaderParameter. Was preventing the return of bools in dart2js. BUG=11487 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=24599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 5 months ago (2013-06-28 15:46:17 UTC) #1
Emily Fortuna
lgtm
7 years, 5 months ago (2013-06-28 17:39:29 UTC) #2
blois
7 years, 5 months ago (2013-06-28 17:54:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24599 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698