Issue 18080015: Revert "Make StreamController be a StreamSink, not just an EventSink."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18080015: Revert "Make StreamController be a StreamSink, not just an EventSink." (Closed)

Created:
7 years, 5 months ago by floitsch

Modified:
7 years, 5 months ago

Reviewers:
Lasse Reichstein Nielsen, ahe

CC:
reviews_dartlang.org, ahe

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Revert "Make StreamController be a StreamSink, not just an EventSink." Revert "Remove type variable to work around dart2js bug." This reverts commit r24587. This reverts commit r24588. Committed: https://code.google.com/p/dart/source/detail?r=24590

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+466 lines, -1014 lines)			Patch
M	sdk/lib/async/async.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/async/async_sources.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sdk/lib/async/broadcast_stream_controller.dart	View	1 chunk	+0 lines, -492 lines	0 comments	Download
M	sdk/lib/async/future_impl.dart	View	7 chunks	+12 lines, -35 lines	0 comments	Download
M	sdk/lib/async/stream.dart	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	sdk/lib/async/stream_controller.dart	View	11 chunks	+436 lines, -356 lines	0 comments	Download
M	sdk/lib/async/stream_impl.dart	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	tests/lib/async/event_helper.dart	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	tests/lib/async/stream_controller_async_test.dart	View	3 chunks	+1 line, -114 lines	0 comments	Download
M	tests/lib/async/stream_controller_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

Need to revert since it triggered a bug in the VM (and there was another ...

7 years, 5 months ago (2013-06-28 15:06:46 UTC) #1

floitsch

Committed patchset #1 manually as r24590 (presubmit successful).

7 years, 5 months ago (2013-06-28 15:07:20 UTC) #3

Message was sent while issue was closed.

lgtm

Thank you, Florian!

Expand Messages | Collapse Messages