Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 18080010: Remove static mutexes/monitors from dart:io. (Closed)

Created:
7 years, 5 months ago by Anders Johnsen
Modified:
7 years, 5 months ago
Reviewers:
ricow1, Bill Hesse, hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove static mutexes/monitors from dart:io. BUG= R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=24576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -63 lines) Patch
M runtime/bin/process.h View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/process.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_android.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M runtime/bin/process_linux.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M runtime/bin/process_macos.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M runtime/bin/process_win.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M runtime/bin/secure_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/secure_socket.cc View 6 chunks +10 lines, -9 lines 0 comments Download
M runtime/bin/socket.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
Let me know if this looks right. I'm not aware of the issue we are ...
7 years, 5 months ago (2013-06-28 06:16:05 UTC) #1
Bill Hesse
lgtm
7 years, 5 months ago (2013-06-28 08:33:36 UTC) #2
Anders Johnsen
Committed patchset #1 manually as r24576 (presubmit successful).
7 years, 5 months ago (2013-06-28 08:44:26 UTC) #3
hausner
7 years, 5 months ago (2013-06-28 15:12:16 UTC) #4
Message was sent while issue was closed.
Thank you.

Powered by Google App Engine
This is Rietveld 408576698