Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 180783008: Change handling of dart-ext: URIs for native extensions. (Closed)

Created:
6 years, 9 months ago by Bill Hesse
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Change handling of dart-ext: URIs for native extensions. With this change, a dart-ext: URI is now an opaque URI consisting of the scheme dart-ext: followed by an actual URI, either relative, or with a scheme like file:, http:, or package:. Existing users are mostly or all using relative URIs, so this change should not affect them. This is a step toward allowing native extensions in packages to be served over http, and also cleans up the code, and would help a future change that replaces "dart-ext:" with metadata or an annotation. BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33216

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make _DART_EXT top-level. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -37 lines) Patch
M runtime/bin/builtin.dart View 1 3 chunks +11 lines, -32 lines 1 comment Download
M runtime/bin/dartutils.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/extensions.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Hesse
A refactoring and cleanup of the dart-ext: code. Needed in order to implement native extensions ...
6 years, 9 months ago (2014-02-27 18:50:50 UTC) #1
Ivan Posva
LGTM -ip https://codereview.chromium.org/180783008/diff/1/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/180783008/diff/1/runtime/bin/builtin.dart#newcode224 runtime/bin/builtin.dart:224: const DART_EXT = 'dart-ext:'; This constant should ...
6 years, 9 months ago (2014-03-03 08:26:37 UTC) #2
Bill Hesse
Committed patchset #2 manually as r33216 (presubmit successful).
6 years, 9 months ago (2014-03-03 14:51:49 UTC) #3
Ivan Posva
-Ivan https://codereview.chromium.org/180783008/diff/20001/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/180783008/diff/20001/runtime/bin/builtin.dart#newcode208 runtime/bin/builtin.dart:208: const _DART_EXT 'dart-ext:'; How does this compile?
6 years, 9 months ago (2014-03-03 20:38:00 UTC) #4
Bill Hesse
6 years, 9 months ago (2014-03-04 09:27:13 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/180783008/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/180783008/diff/1/runtime/bin/builtin.dart#new...
runtime/bin/builtin.dart:224: const DART_EXT = 'dart-ext:';
On 2014/03/03 08:26:37, Ivan Posva wrote:
> This constant should only be defined once. How about a top-level _DART_EXT?

Done.  Committed with a typo in r33216, fixed in r33217.

Powered by Google App Engine
This is Rietveld 408576698