Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1807413002: Disallow names and plain_names in a test context. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M lib/src/runner/configuration/load.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 9 months ago (2016-03-18 00:22:39 UTC) #1
kevmoo
lgtm
4 years, 9 months ago (2016-03-21 20:12:46 UTC) #2
nweiz
4 years, 9 months ago (2016-03-21 20:30:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3d036c3a1e006e152f48ba75ab3fa1025f03df68 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698