Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 18073003: dart:io | Add automated testing for samples/sample_extension to buildbot. (Closed)

Created:
7 years, 5 months ago by Bill Hesse
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Add automated testing for samples/sample_extension to buildbot. BUG=dartbug.com/3008 R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=25612

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add sample_extension to the targets of the runtime build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -2 lines) Patch
M dart.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M samples/sample_extension/test_sample_asynchronous_extension.dart View 1 chunk +0 lines, -1 line 0 comments Download
M samples/sample_extension/test_sample_synchronous_extension.dart View 1 chunk +0 lines, -1 line 0 comments Download
A samples/tests/samples/standalone/sample_extension_test.dart View 1 chunk +71 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bill Hesse
7 years, 5 months ago (2013-06-27 16:08:16 UTC) #1
Anders Johnsen
+ricow, Can you check if this will work on buildbots? What if we just renamed ...
7 years, 5 months ago (2013-06-27 16:22:48 UTC) #2
Bill Hesse
On 2013/06/27 16:22:48, Anders Johnsen wrote: > +ricow, Can you check if this will work ...
7 years, 5 months ago (2013-06-27 16:37:27 UTC) #3
Anders Johnsen
I see, thanks for explaining! LGTM
7 years, 5 months ago (2013-06-27 16:46:51 UTC) #4
ricow1
[+ahe]
7 years, 5 months ago (2013-06-28 10:33:49 UTC) #5
Bill Hesse
Added the samples/sample_extension target to the runtime build. PTAL.
7 years, 5 months ago (2013-07-04 14:11:37 UTC) #6
Bill Hesse
7 years, 4 months ago (2013-07-30 12:16:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r25612 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698