Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 180723004: Use Date.getTime instead of Date.getMilliseconds in dart:js. (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 9 months ago
Reviewers:
justinfagnani, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use Date.getTime instead of Date.getMilliseconds in dart:js. BUG= http://dartbug.com/14915 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=33116

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M sdk/lib/js/dart2js/js_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/lib/js/datetime_roundtrip_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
floitsch
6 years, 10 months ago (2014-02-26 12:47:32 UTC) #1
john.collier4
On 2014/02/26 12:47:32, floitsch wrote: Looks good.
6 years, 10 months ago (2014-02-26 15:49:34 UTC) #2
floitsch
6 years, 9 months ago (2014-02-27 14:48:56 UTC) #3
kasperl
LGTM. https://codereview.chromium.org/180723004/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/180723004/diff/1/tests/lib/lib.status#newcode178 tests/lib/lib.status:178: [ $runtime == vm ] What if runtime ...
6 years, 9 months ago (2014-02-27 14:58:59 UTC) #4
floitsch
https://codereview.chromium.org/180723004/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/180723004/diff/1/tests/lib/lib.status#newcode178 tests/lib/lib.status:178: [ $runtime == vm ] On 2014/02/27 14:58:59, kasperl ...
6 years, 9 months ago (2014-02-27 15:02:44 UTC) #5
floitsch
Committed patchset #1 manually as r33116 (presubmit successful).
6 years, 9 months ago (2014-02-27 15:13:51 UTC) #6
justinfagnani
6 years, 9 months ago (2014-02-27 15:49:18 UTC) #7
Message was sent while issue was closed.
On 2014/02/27 15:13:51, floitsch wrote:
> Committed patchset #1 manually as r33116 (presubmit successful).

Sorry for the late lgtm, I was sick for the last two days.

Powered by Google App Engine
This is Rietveld 408576698