Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 18065003: Update checked in binary to version 0.5.19.0 (Closed)

Created:
7 years, 5 months ago by ricow1
Modified:
7 years, 5 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update checked in binary to version 0.5.19.0 This is a reland of r24086 with a fix catching errors in the websocket server in tools/testing/dart/http_server.dart. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=24520

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -46 lines) Patch
M tools/release/version.dart View 1 2 chunks +6 lines, -5 lines 0 comments Download
M tools/testing/dart/browser_controller.dart View 1 8 chunks +8 lines, -8 lines 0 comments Download
M tools/testing/dart/http_server.dart View 1 3 chunks +6 lines, -4 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/record_and_replay.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_progress.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 8 chunks +17 lines, -18 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
7 years, 5 months ago (2013-06-27 16:03:19 UTC) #1
ricow1
Removed the change to enable the test_runner test, the new binary is already incompatible with ...
7 years, 5 months ago (2013-06-27 16:09:47 UTC) #2
kustermann
lgtm
7 years, 5 months ago (2013-06-27 16:09:47 UTC) #3
ricow1
7 years, 5 months ago (2013-06-27 16:11:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r24520 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698