Issue 180633006: Status files merge sections

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180633006: Status files merge sections (Closed)

Created:
6 years, 9 months ago by sigurdm

Modified:
6 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Status files merge sections R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=33261

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	tests/lib/lib.status	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/180633006/diff/1/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/180633006/diff/1/tests/lib/lib.status#newcode21 tests/lib/lib.status:21: mirrors/deferred_mirrors_metadata_test: Fail # http://dartbug.com/16898 Use "Issue 16898" as ...

6 years, 9 months ago (2014-03-03 16:06:44 UTC) #2

sigurdm

Committed patchset #2 manually as r33261 (presubmit successful).

6 years, 9 months ago (2014-03-04 08:05:39 UTC) #3

sigurdm

6 years, 9 months ago (2014-03-04 08:06:38 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/180633006/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/180633006/diff/1/tests/lib/lib.status#newcode21
tests/lib/lib.status:21: mirrors/deferred_mirrors_metadata_test: Fail #
http://dartbug.com/16898
On 2014/03/03 16:06:44, floitsch wrote:
> Use "Issue 16898" as in the line above.

Done.

Expand Messages | Collapse Messages

Issue 180633006: Status files merge sections (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages