Issue 180633005: Status files update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180633005: Status files update. (Closed)

Created:
6 years, 9 months ago by sigurdm

Modified:
6 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Status files update. Deferred loading does not work in csp mode. Committed: https://code.google.com/p/dart/source/detail?r=33218

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/lib/lib.status	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sigurdm

Committed patchset #1 manually as r33218 (presubmit successful).

6 years, 9 months ago (2014-03-03 15:22:27 UTC) #3

floitsch

6 years, 9 months ago (2014-03-03 15:38:19 UTC) #4

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/180633005/diff/1/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/180633005/diff/1/tests/lib/lib.status#newcode20
tests/lib/lib.status:20: async/deferred/deferred_in_isolate_test: RuntimeError #
 Issue 16898
We already have a csp section. Add it here.

Expand Messages | Collapse Messages