Issue 180583002: Fix for FileReader.readAsArrayBuffer http://dartbug.com/17058

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 180583002: Fix for FileReader.readAsArrayBuffer http://dartbug.com/17058 (Closed)

Created:
6 years, 10 months ago by sra1

Modified:
6 years, 8 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix for FileReader.readAsArrayBuffer http://dartbug.com/17058 R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=33048

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -24 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		4 chunks	+13 lines, -6 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		2 chunks	+6 lines, -6 lines	0 comments	Download
A	tests/html/filereader_test.dart	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View		2 chunks	+4 lines, -3 lines	0 comments	Download
A +	tools/dom/templates/html/impl/impl_FileReader.darttemplate	View		2 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm https://codereview.chromium.org/180583002/diff/40001/tests/html/filereader_test.dart File tests/html/filereader_test.dart (right): https://codereview.chromium.org/180583002/diff/40001/tests/html/filereader_test.dart#newcode7 tests/html/filereader_test.dart:7: import '../../pkg/unittest/lib/html_config.dart'; Not critical, but prefer the package:unittest/unittest.dart ...

6 years, 10 months ago (2014-02-26 00:24:01 UTC) #2

sra1

6 years, 10 months ago (2014-02-26 00:31:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r33048 (presubmit successful).

Expand Messages | Collapse Messages

Issue 180583002: Fix for FileReader.readAsArrayBuffer http://dartbug.com/17058 (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages