Issue 18055004: Fix a bug in allocation sinking and load elimination.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18055004: Fix a bug in allocation sinking and load elimination. (Closed)

Created:
7 years, 5 months ago by Florian Schneider

Modified:
7 years, 5 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix a bug in allocation sinking and load elimination. 1. Aliasing information was not computed for allocations that are never used in a LoadField instruction. 2. CanBeAliased was not correct in the case of a StoreVMField. BUG=https://code.google.com/p/dart/issues/detail?id=11538 TEST=runtime/vm/flow_graph_optimizer.cc R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=24515

Patch Set 1 #

Total comments: 1

Patch Set 2 : improved unit test #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -37 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		5 chunks	+33 lines, -37 lines	1 comment	Download
	M	tests/language/allocation_sinking_vm_test.dart	View	1	2 chunks	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

https://codereview.chromium.org/18055004/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/18055004/diff/1/runtime/vm/flow_graph_optimizer.cc#newcode4062 runtime/vm/flow_graph_optimizer.cc:4062: (instr->IsStoreVMField() && (use->use_index() != 1)) || This function became ...

7 years, 5 months ago (2013-06-27 13:03:40 UTC) #1

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/18055004/diff/4001/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/18055004/diff/4001/runtime/vm/flow_graph_optimizer.cc#newcode4062 runtime/vm/flow_graph_optimizer.cc:4062: (instr->IsStoreVMField() && (use->use_index() != 1)) || Good catch!

7 years, 5 months ago (2013-06-27 13:15:45 UTC) #2

Florian Schneider

7 years, 5 months ago (2013-06-27 13:26:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r24515 (presubmit successful).

Expand Messages | Collapse Messages