Issue 18054022: Fix 11574: Smi is a subtype of parametrizable Compare.

Issue 18054022: Fix 11574: Smi is a subtype of parametrizable Compare. (Closed)

Created:
7 years, 5 months ago by srdjan

Modified:
7 years, 5 months ago

Reviewers:
zra, regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix 11574: Smi is a subtype of parametrizable Compare. R=regis@google.com, zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=24612

Patch Set 4 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -12 lines)			Patch
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2	2 chunks	+10 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2	2 chunks	+10 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2 3	2 chunks	+10 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2	2 chunks	+10 lines, -3 lines	0 comments	Download
A	tests/language/smi_type_test.dart	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM, without the typo. https://codereview.chromium.org/18054022/diff/11001/runtime/vm/flow_graph_compiler_mips.cc File runtime/vm/flow_graph_compiler_mips.cc (right): https://codereview.chromium.org/18054022/diff/11001/runtime/vm/flow_graph_compiler_mips.cc#newcode235 runtime/vm/flow_graph_compiler_mips.cc:235: __ beq(CMPRES, ZR, is_not_instance_lbl); is_instance_lbl

7 years, 5 months ago (2013-06-28 22:07:09 UTC) #2

srdjan

https://codereview.chromium.org/18054022/diff/11001/runtime/vm/flow_graph_compiler_mips.cc File runtime/vm/flow_graph_compiler_mips.cc (right): https://codereview.chromium.org/18054022/diff/11001/runtime/vm/flow_graph_compiler_mips.cc#newcode235 runtime/vm/flow_graph_compiler_mips.cc:235: __ beq(CMPRES, ZR, is_not_instance_lbl); On 2013/06/28 22:07:09, regis wrote: ...

7 years, 5 months ago (2013-06-28 22:11:34 UTC) #3

srdjan

7 years, 5 months ago (2013-06-28 22:31:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r24612 (presubmit successful).

Expand Messages | Collapse Messages