Dynamic is a subtype of any type.

Dynamic is a subtype of any type.

Technically not, effectively yes.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=24596

[Brian Wilkerson, 2013-06-28 13:19:23]

LGTM once the code I commented on is restored.

https://codereview.chromium.org/18054013/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java
(left):

https://codereview.chromium.org/18054013/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java:77:
int length = parameterTypes.length;
While this is no longer needed in order to effectively get the substitution of
[bottom/dynamic]dynamic, I think it's still the correct implementation for
something like [int/dynamic]dynamic. No, I don't think we actually do this, but
there's no reason why this method shouldn't work correctly.

[jwren, 2013-06-28 16:00:26]

LGTM

[scheglov, 2013-06-28 16:47:29]

https://codereview.chromium.org/18054013/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java
(left):

https://codereview.chromium.org/18054013/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/DynamicTypeImpl.java:77:
int length = parameterTypes.length;
On 2013/06/28 13:19:23, Brian Wilkerson wrote:
> While this is no longer needed in order to effectively get the substitution of
> [bottom/dynamic]dynamic, I think it's still the correct implementation for
> something like [int/dynamic]dynamic. No, I don't think we actually do this,
but
> there's no reason why this method shouldn't work correctly.

Done.

[scheglov, 2013-06-28 16:47:49]

Committed patchset #2 manually as r24596 (presubmit successful).