Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 18053012: Report ILLEGAL_CHARACTER for nbsp. (Closed)

Created:
7 years, 5 months ago by scheglov
Modified:
7 years, 5 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report ILLEGAL_CHARACTER for nbsp. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24552

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/scanner/AbstractScanner.java View 2 chunks +0 lines, -12 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/scanner/AbstractScannerTest.java View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/co19/co19-analyzer.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 5 months ago (2013-06-27 21:16:42 UTC) #1
Brian Wilkerson
LGTM
7 years, 5 months ago (2013-06-27 21:25:01 UTC) #2
scheglov
Committed patchset #1 manually as r24552 (presubmit successful).
7 years, 5 months ago (2013-06-27 21:28:43 UTC) #3
jwren
7 years, 5 months ago (2013-06-27 21:33:41 UTC) #4
Message was sent while issue was closed.
On 2013/06/27 21:28:43, scheglov wrote:
> Committed patchset #1 manually as r24552 (presubmit successful).

LGTM

Powered by Google App Engine
This is Rietveld 408576698