Issue 18053010: Equality can be converted to a strict equality with checks. If the number of checks exceeds the thr…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18053010: Equality can be converted to a strict equality with checks. If the number of checks exceeds the thr… (Closed)

Created:
7 years, 5 months ago by srdjan

Modified:
7 years, 5 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Equality can be converted to a strict equality with checks. If the number of checks exceeds the threshold (--max_equality_polymorphic_checks=32) use megamorphic dispatch instead. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=24592

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -17 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	3 chunks	+7 lines, -4 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

srdjan

7 years, 5 months ago (2013-06-28 16:15:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r24592 (presubmit successful).