Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 18051016: Do report StaticWarningCode.FINAL_NOT_INITIALIZED (Closed)

Created:
7 years, 5 months ago by scheglov
Modified:
7 years, 5 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Do report StaticWarningCode.FINAL_NOT_INITIALIZED Mostly just enable the implementation done by Jaime and some clean up. There are many positives in dart2js, in HTML related libraries. It seems that the most or all of these positives are in the classes with native implementation. So, may be worth to remember that class has native implementation and don't report this problem. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=24815

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't report for native classes #

Messages

Total messages: 5 (0 generated)
scheglov
7 years, 5 months ago (2013-07-07 20:28:52 UTC) #1
Brian Wilkerson
> There are many positives in dart2js, in HTML related libraries. > It seems that ...
7 years, 5 months ago (2013-07-08 13:39:29 UTC) #2
scheglov
PTAL Now we don't report this problem with the native classes. There are still 7 ...
7 years, 5 months ago (2013-07-08 18:46:41 UTC) #3
Brian Wilkerson
LGTM
7 years, 5 months ago (2013-07-08 18:50:24 UTC) #4
scheglov
7 years, 5 months ago (2013-07-08 18:54:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r24815 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698