Issue 18042008: createPatternFromImage doesn't work on Firefox. Removing until we have a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18042008: createPatternFromImage doesn't work on Firefox. Removing until we have a (Closed)

Created:
7 years, 5 months ago by Emily Fortuna

Modified:
7 years, 5 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

createPatternFromImage doesn't work on Firefox. Removing until we have a pollyfill. BUG= Committed: https://code.google.com/p/dart/source/detail?r=24710

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/html/canvasrenderingcontext2d_test.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

TBR. I added this test in the previous CL, but apparently it doesn't work on ...

7 years, 5 months ago (2013-07-02 23:42:18 UTC) #1

Emily Fortuna

Committed patchset #1 manually as r24710 (presubmit successful).

7 years, 5 months ago (2013-07-02 23:42:35 UTC) #2

Jennifer Messerly

7 years, 5 months ago (2013-07-02 23:51:37 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/18042008/diff/1/tests/html/canvasrenderingcon...
File tests/html/canvasrenderingcontext2d_test.dart (right):

https://codereview.chromium.org/18042008/diff/1/tests/html/canvasrenderingcon...
tests/html/canvasrenderingcontext2d_test.dart:674: //var pattern2 =
context.createPatternFromImage(new ImageElement(), '');
is it possible to guard this in some sort of an `if (!firefox)` ?

(or maybe catch the "component not available" exception, if that's a valid
result?)

Expand Messages | Collapse Messages