Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 18042002: dart:io | Add rename() and renameSync() to FileSystem Entity (Closed)

Created:
7 years, 5 months ago by Bill Hesse
Modified:
7 years, 5 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Add rename() and renameSync() to FileSystem Entity The subclasses all implement these already. BUG= R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=24511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M sdk/lib/io/file_system_entity.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
The functions are also kept on the subclasses, with more specific (covariant) return types.
7 years, 5 months ago (2013-06-27 09:02:05 UTC) #1
Anders Johnsen
lgtm
7 years, 5 months ago (2013-06-27 09:06:11 UTC) #2
Bill Hesse
7 years, 5 months ago (2013-06-27 09:18:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r24511 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698