Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 180363003: Work around issue 17083 in pkg/stack_trace. (Closed)

Created:
6 years, 10 months ago by nweiz
Modified:
6 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Work around issue 17083 in pkg/stack_trace. This also properly reports timer_impl.dart as being in dart:io rather than dart:async. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=33039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M pkg/stack_trace/lib/src/frame.dart View 2 chunks +10 lines, -4 lines 0 comments Download
M pkg/stack_trace/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/stack_trace/test/frame_test.dart View 1 chunk +19 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 10 months ago (2014-02-25 21:42:40 UTC) #1
Bob Nystrom
lgtm
6 years, 10 months ago (2014-02-25 22:05:04 UTC) #2
nweiz
6 years, 10 months ago (2014-02-25 22:36:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r33039 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698