Issue 18034027: Handle do-while

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18034027: Handle do-while (Closed)

Created:
7 years, 5 months ago by polux

Modified:
7 years, 5 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle do-while R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=25212

Patch Set 2 : Sync to head, address comments. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -5 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1	5 chunks	+12 lines, -5 lines	0 comments	Download
	M	tests/compiler/dart2js/cpa_inference_test.dart	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/18034027/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://codereview.chromium.org/18034027/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode1680 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1680: ConcreteType result = inferrer.emptyConcreteType; Inline the value in ...

7 years, 5 months ago (2013-07-15 14:02:40 UTC) #2

polux

7 years, 5 months ago (2013-07-19 13:13:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r25212 (presubmit successful).

Expand Messages | Collapse Messages

Issue 18034027: Handle do-while (Closed)

Description

Patch Set 1 #

Patch Set 2 : Sync to head, address comments. #

Messages