Error handling and code cleanup

Error handling and code cleanup
+ cleanup futures code and error handling
+ send message to request server shutdown
+ normalize strings to match codebase

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33063

[Brian Wilkerson, 2014-02-25 23:36:06]

LGTM

https://codereview.chromium.org/180253005/diff/20001/pkg/analysis_server/bin/...
File pkg/analysis_server/bin/dartdeps.dart (right):

https://codereview.chromium.org/180253005/diff/20001/pkg/analysis_server/bin/...
pkg/analysis_server/bin/dartdeps.dart:68: * Return `null` if the command line
arguments are invalid.
Do we really want to return null? I would have thought that we wanted to return
a "new Future.value(null)" so that the 'then' in 'run' would not produce an NPE.

[danrubel, 2014-02-26 14:33:46]

https://codereview.chromium.org/180253005/diff/20001/pkg/analysis_server/bin/...
File pkg/analysis_server/bin/dartdeps.dart (right):

https://codereview.chromium.org/180253005/diff/20001/pkg/analysis_server/bin/...
pkg/analysis_server/bin/dartdeps.dart:68: * Return `null` if the command line
arguments are invalid.
On 2014/02/25 23:36:06, Brian Wilkerson wrote:
> Do we really want to return null? I would have thought that we wanted to
return
> a "new Future.value(null)" so that the 'then' in 'run' would not produce an
NPE.

I wrapped the call to start in a future so that there won't be any NPE.

[danrubel, 2014-02-26 14:39:45]

Committed patchset #3 manually as r33063 (presubmit successful).