Add names and plain_names fields.

Add names and plain_names fields.

This also adds the ability to pass --name or --plain-name multiple times
on the command line.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/3bef4670c1a3d23ebc5a285bced47c09c00d0562

[kevmoo, 2016-03-14 23:08:47]

lgtm

https://codereview.chromium.org/1802133002/diff/1/doc/package_config.md
File doc/package_config.md (right):

https://codereview.chromium.org/1802133002/diff/1/doc/package_config.md#newco...
doc/package_config.md:219: names:
should be `plain_names:` ?

https://codereview.chromium.org/1802133002/diff/1/lib/src/runner.dart
File lib/src/runner.dart (right):

https://codereview.chromium.org/1802133002/diff/1/lib/src/runner.dart#newcode131
lib/src/runner.dart:131: toSentence(_config.patterns.map((pattern) =>
I'd create a variable for the toSentence output and use normal string
interpolation here – tough to read

[nweiz, 2016-03-14 23:19:53]

Code review changes

[nweiz, 2016-03-14 23:20:25]

https://codereview.chromium.org/1802133002/diff/1/doc/package_config.md
File doc/package_config.md (right):

https://codereview.chromium.org/1802133002/diff/1/doc/package_config.md#newco...
doc/package_config.md:219: names:
On 2016/03/14 23:08:47, kevmoo wrote:
> should be `plain_names:` ?

Done.

https://codereview.chromium.org/1802133002/diff/1/lib/src/runner.dart
File lib/src/runner.dart (right):

https://codereview.chromium.org/1802133002/diff/1/lib/src/runner.dart#newcode131
lib/src/runner.dart:131: toSentence(_config.patterns.map((pattern) =>
On 2016/03/14 23:08:47, kevmoo wrote:
> I'd create a variable for the toSentence output and use normal string
> interpolation here – tough to read

Done.

[nweiz, 2016-03-14 23:20:32]

Description was changed from

==========
Add names and plain_names fields.

This also adds the ability to pass --name or --plain-name multiple times
on the command line.

R=kevmoo@google.com
==========

to

==========
Add names and plain_names fields.

This also adds the ability to pass --name or --plain-name multiple times
on the command line.

R=kevmoo@google.com

Committed:
https://github.com/dart-lang/test/commit/3bef4670c1a3d23ebc5a285bced47c09c00d...
==========

[nweiz, 2016-03-14 23:20:33]

Committed patchset #2 (id:20001) manually as
3bef4670c1a3d23ebc5a285bced47c09c00d0562 (presubmit successful).