Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 180153009: Fix dartium crasher, use DARTSCOPE when getting/setting native fields as it creates a Handle. (Closed)

Created:
6 years, 9 months ago by siva
Modified:
6 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix dartium crasher, use DARTSCOPE when getting/setting native fields as it creates a Handle. Committed: https://code.google.com/p/dart/source/detail?r=33148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M runtime/vm/dart_api_impl.cc View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
TBR=rmacnak
6 years, 9 months ago (2014-02-28 03:22:09 UTC) #1
siva
Committed patchset #1 manually as r33148 (presubmit successful).
6 years, 9 months ago (2014-02-28 03:22:18 UTC) #2
rmacnak
6 years, 9 months ago (2014-02-28 18:03:39 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698