Add package with iterable and stream "zipping" functionality.

Add package with iterable and stream "zipping" functionality.

You can use new IterableZip([it1, it2, it3]) to generate an iterable of
three-element lists, one from each source iterable, as long as all three
source iterables have an element.

Similar functionality for streams is provided by StreamZip.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=24835

[Lasse Reichstein Nielsen, 2013-07-04 11:40:38]

PTAL

[Lasse Reichstein Nielsen, 2013-07-04 11:40:38]

PTAL

[floitsch, 2013-07-04 14:31:22]

LGTM, but add test for pause/resume.

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/iterable...
File pkg/sequence_zip/lib/iterable_zip.dart (right):

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/iterable...
pkg/sequence_zip/lib/iterable_zip.dart:17: * [Iterable]'s [Iterator]. As soon as
any of the iterators run out.
unfinished sentence.

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
File pkg/sequence_zip/lib/stream_zip.dart (right):

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
pkg/sequence_zip/lib/stream_zip.dart:45: /// is used insted.
instead

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
pkg/sequence_zip/lib/stream_zip.dart:47: controller.addError(error);
Should you also increase the dataCount and pause this stream?

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
pkg/sequence_zip/lib/stream_zip.dart:90: // These will not be resumed by
onResume below, but must wait for the
good thing pause/resume is counting ;)

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
pkg/sequence_zip/lib/stream_zip.dart:97: subscriptions[i].pause();
resume.

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/test/stream_...
File pkg/sequence_zip/test/stream_test.dart (right):

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/test/stream_...
pkg/sequence_zip/test/stream_test.dart:93: Stream st2 = new
Stream.periodic(const Duration(milliseconds: 5),
This means that the test won't work in d8.

[Lasse Reichstein Nielsen, 2013-07-09 05:49:41]

Committed patchset #2 manually as r24835 (presubmit successful).

[Lasse Reichstein Nielsen, 2013-07-09 06:15:59]

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/iterable...
File pkg/sequence_zip/lib/iterable_zip.dart (right):

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/iterable...
pkg/sequence_zip/lib/iterable_zip.dart:17: * [Iterable]'s [Iterator]. As soon as
any of the iterators run out.
On 2013/07/04 14:31:22, floitsch wrote:
> unfinished sentence.

Done.

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
File pkg/sequence_zip/lib/stream_zip.dart (right):

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
pkg/sequence_zip/lib/stream_zip.dart:45: /// is used insted.
On 2013/07/04 14:31:22, floitsch wrote:
> instead

Done.

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
pkg/sequence_zip/lib/stream_zip.dart:47: controller.addError(error);
No. I decided that an error is not a replacement for data. We are still waiting
for the data.

I really, really recommend using cancelOnError when using this in any case.

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
pkg/sequence_zip/lib/stream_zip.dart:90: // These will not be resumed by
onResume below, but must wait for the
Yes! I finally found a case where it is exactly what I needed!

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/lib/stream_z...
pkg/sequence_zip/lib/stream_zip.dart:97: subscriptions[i].pause();
Hmm. That does look like a failure of the testing.

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/test/stream_...
File pkg/sequence_zip/test/stream_test.dart (right):

https://codereview.chromium.org/18015002/diff/1/pkg/sequence_zip/test/stream_...
pkg/sequence_zip/test/stream_test.dart:93: Stream st2 = new
Stream.periodic(const Duration(milliseconds: 5),
I'll mark it as failing.