Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801363007: Add pause_after_load to the config file. (Closed)

Created:
4 years, 9 months ago by nweiz
Modified:
4 years, 9 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -0 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M doc/package_config.md View 1 2 chunks +19 lines, -0 lines 0 comments Download
M lib/src/runner/configuration/load.dart View 3 chunks +4 lines, -0 lines 0 comments Download
M test/runner/configuration/top_level_error_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M test/runner/configuration/top_level_test.dart View 2 chunks +46 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 9 months ago (2016-03-17 22:38:39 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1801363007/diff/1/doc/package_config.md File doc/package_config.md (right): https://codereview.chromium.org/1801363007/diff/1/doc/package_config.md#newcode298 doc/package_config.md:298: # Pass -P debug to enable debugging configuration ...
4 years, 9 months ago (2016-03-21 20:12:24 UTC) #2
nweiz
Code review changes
4 years, 9 months ago (2016-03-21 20:27:23 UTC) #3
nweiz
https://codereview.chromium.org/1801363007/diff/1/doc/package_config.md File doc/package_config.md (right): https://codereview.chromium.org/1801363007/diff/1/doc/package_config.md#newcode298 doc/package_config.md:298: # Pass -P debug to enable debugging configuration On ...
4 years, 9 months ago (2016-03-21 20:27:54 UTC) #4
nweiz
4 years, 9 months ago (2016-03-21 20:28:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f590d4696ff7ca9b2ce6a8fef591aa3589d14316 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698