Issue 180113009: Pretenure large external typed data and strings.

Issue 180113009: Pretenure large external typed data and strings. (Closed)

Created:
6 years, 9 months ago by koda

Modified:
6 years, 9 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Pretenure large external typed data and strings. Also fix an incorrect API comment about handle return type. BUG=dart:17284 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=33344

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -6 lines)			Patch
M	runtime/include/dart_api.h	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View		4 chunks	+28 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1 2 3	1 chunk	+81 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/180113009/diff/40001/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/180113009/diff/40001/runtime/vm/dart_api_impl_test.cc#newcode1047 runtime/vm/dart_api_impl_test.cc:1047: EXPECT(handle.IsOld()); How about also testing that small ...

6 years, 9 months ago (2014-03-05 20:48:42 UTC) #2

koda

https://codereview.chromium.org/180113009/diff/40001/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/180113009/diff/40001/runtime/vm/dart_api_impl_test.cc#newcode1047 runtime/vm/dart_api_impl_test.cc:1047: EXPECT(handle.IsOld()); On 2014/03/05 20:48:42, Ivan Posva wrote: > How ...

6 years, 9 months ago (2014-03-05 21:08:59 UTC) #3

koda

6 years, 9 months ago (2014-03-05 21:09:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r33344 (presubmit successful).

Expand Messages | Collapse Messages