Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 17982002: remove warning that is no longer in dart:html (Closed)

Created:
7 years, 6 months ago by Jennifer Messerly
Modified:
7 years, 5 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

remove warning that is no longer in dart:html TBR to fix dart2js bot. Committed: https://code.google.com/p/dart/source/detail?r=24503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tests/compiler/dart2js/analyze_api_test.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
for what it's worth: I thought I ran the test this time, but I must've ...
7 years, 6 months ago (2013-06-27 00:44:51 UTC) #1
Jennifer Messerly
Committed patchset #1 manually as r24503 (presubmit successful).
7 years, 6 months ago (2013-06-27 00:45:14 UTC) #2
ahe
lgtm
7 years, 6 months ago (2013-06-27 08:19:28 UTC) #3
ahe
On 2013/06/27 00:44:51, John Messerly wrote: > for what it's worth: I thought I ran ...
7 years, 6 months ago (2013-06-27 08:22:46 UTC) #4
Jennifer Messerly
7 years, 5 months ago (2013-06-27 18:19:10 UTC) #5
Message was sent while issue was closed.
On 2013/06/27 08:22:46, ahe wrote:
> On 2013/06/27 00:44:51, John Messerly wrote:
> > for what it's worth: I thought I ran the test this time, but I must've ran
it
> > incorrectly. I was able to reproduce the error via:
> > 
> > python tools/test.py -m release --checked dart2js/analyze_api_test
> 
> I know it is too complicated testing dart2js, but at least it is documented
:-)
> 
> But what does that help if you don't know where the documentation is? So for
> future reference, here it is:
> 
> https://code.google.com/p/dart/wiki/TestingDart2js#Basic_test_recommendation

Thanks Peter, that link is very helpful! I'll keep in mind the dart2js_developer
script, it sounds very useful.

Powered by Google App Engine
This is Rietveld 408576698