Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 179783007: Fix for 15001. (Closed)

Created:
6 years, 9 months ago by jwren
Modified:
6 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 4 (0 generated)
jwren
6 years, 9 months ago (2014-03-04 19:13:19 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/179783007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/InheritanceManager.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/InheritanceManager.java (right): https://codereview.chromium.org/179783007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/InheritanceManager.java#newcode212 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/InheritanceManager.java:212: * Given some {@link ExecutableElement} return cast the ...
6 years, 9 months ago (2014-03-04 19:22:37 UTC) #2
jwren
https://codereview.chromium.org/179783007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/InheritanceManager.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/InheritanceManager.java (right): https://codereview.chromium.org/179783007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/InheritanceManager.java#newcode212 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/InheritanceManager.java:212: * Given some {@link ExecutableElement} return cast the element ...
6 years, 9 months ago (2014-03-04 19:46:03 UTC) #3
jwren
6 years, 9 months ago (2014-03-04 19:49:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r33293 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698